Skip to content

Bump aiohasupervisor to 0.4.1#165489

Merged
sairon merged 4 commits into
devfrom
bump-aiohasupervisor-0.4.0
Mar 16, 2026
Merged

Bump aiohasupervisor to 0.4.1#165489
sairon merged 4 commits into
devfrom
bump-aiohasupervisor-0.4.0

Conversation

@mdegat01

@mdegat01 mdegat01 commented Mar 13, 2026 •
edited by agners
Loading

Copy link
Copy Markdown
Contributor

Proposed change

Bumps aiohasupervisor from version 0.3.3 to 0.4.1

I was going to bump the value in pyproject.toml as well but I see that @edenhaus put in a PR to make that unnecessary and we're overdue from removing it from there. So I removed it instead of bumping it in this PR but let me know if you'd prefer that bit in a separate PR since I guess its possible it could be breaking for custom integrations.

This change moved to #165512 . This PR will wait for that to merge

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@mdegat01 mdegat01 requested review from agners and edenhaus March 13, 2026 19:03
@mdegat01 mdegat01 requested a review from a team as a code owner March 13, 2026 19:03
Copilot AI review requested due to automatic review settings March 13, 2026 19:03
@home-assistant home-assistant Bot added cla-signed core dependency Pull requests marked as a dependency upgrade integration: hassio small-pr PRs with less than 30 lines. by-code-owner Quality Scale: internal labels Mar 13, 2026
@home-assistant

home-assistant Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI reviewed Mar 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps aiohasupervisor from 0.3.3 to 0.4.0 and removes it as a core dependency from pyproject.toml, requirements.txt, and package_constraints.txt, keeping it only as a requirement of the hassio integration.

Changes:

  • Bumps aiohasupervisor version from 0.3.3 to 0.4.0 in manifest.json, requirements_all.txt, and requirements_test_all.txt.
  • Removes aiohasupervisor from core-level dependency files (pyproject.toml, requirements.txt, package_constraints.txt) since it should only be a hassio integration dependency (related to the deprecation note from #127228, originally targeted for removal with 2025.11).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/hassio/manifest.json Bumps aiohasupervisor to 0.4.0
requirements_all.txt Bumps aiohasupervisor to 0.4.0
requirements_test_all.txt Bumps aiohasupervisor to 0.4.0
pyproject.toml Removes aiohasupervisor as a core dependency
requirements.txt Removes aiohasupervisor from core requirements
homeassistant/package_constraints.txt Removes aiohasupervisor from package constraints

@mdegat01 mdegat01 force-pushed the bump-aiohasupervisor-0.4.0 branch from 5bff7be to d826323 Compare March 13, 2026 19:42
Copilot AI review requested due to automatic review settings March 13, 2026 19:42
@mdegat01 mdegat01 mentioned this pull request Mar 13, 2026
Merged
21 tasks
Copilot AI reviewed Mar 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps aiohasupervisor from 0.3.3 to 0.4.0 and removes the library from the core dependency list (pyproject.toml, requirements.txt, package_constraints.txt), keeping it only as a hassio integration requirement.

Changes:

  • Version bump of aiohasupervisor to 0.4.0 in manifest and generated requirements files.
  • Removal of aiohasupervisor from core dependencies (pyproject.toml, requirements.txt, package_constraints.txt) since it should only be an integration-level dependency.
  • Test updates replacing removed enum values (CheckType.SUPERVISOR_TRUST → DOCKER_CONFIG, UnsupportedReason.CONTENT_TRUST → CONNECTIVITY_CHECK).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/hassio/manifest.json Bump aiohasupervisor version to 0.4.0
requirements_all.txt Bump aiohasupervisor version to 0.4.0
requirements_test_all.txt Bump aiohasupervisor version to 0.4.0
requirements.txt Remove aiohasupervisor from core requirements
pyproject.toml Remove aiohasupervisor from core dependencies
homeassistant/package_constraints.txt Remove aiohasupervisor from package constraints
tests/components/hassio/test_issues.py Update tests to use new enum values available in 0.4.0

@agners

agners commented Mar 13, 2026

Copy link
Copy Markdown
Member

I was going to bump the value in pyproject.toml as well but I see that @edenhaus put in a PR to make that unnecessary and we're overdue from removing it from there. So I removed it instead of bumping it in this PR but let me know if you'd prefer that bit in a separate PR since I guess its possible it could be breaking for custom integrations.

By the PR you mean #127228? That PR added deprecated functions like get_supervisor_ip. I am not sure, but isn't the library in pyproject.yaml necessary because of these functions are still present? I think it would be better to remove the deprecated functions along with the pyproject.yaml entry in a separate PR.

@mdegat01 mdegat01 mentioned this pull request Mar 13, 2026
Merged
21 tasks
@mdegat01

mdegat01 commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

By the PR you mean #127228? That PR added deprecated functions like get_supervisor_ip.

@agners The main thing that PR did that was relevant to this discussion was it removed hassio from ALLOWED_USED_COMPONENTS here: https://github.com/home-assistant/core/pull/127228/changes#diff-569f8044f69e10d196eb0d217ebfad4ca13e5b61bff3a124b1818b19c0de4bd7 . This was the reason aiohasupervisor had to be in pyproject.toml, hassfest was not enforcing that integration developers listed a dependency on the hassio integration in their manifest. This meant that they could end up in a situation where they depended on aiohasupervisor but it wasn't there at runtime because hassio wasn't installed.

Now all integrations that depend on the hassio integration must declare that. Which means core will also recognize that they depend on aiohasupervisor and make sure its there for them. Since this was done 10/2024 its well past our deprecation/support period and its now safe to remove this dependency from pyproject.toml. We can assume that any integration which needs hassio and aiohasupervisor has that dependency declared in their manifest.

That being said, splitting it into two PRs for release note purposes is fine by me if we want. One to remove the dependency from pyproject.toml and one to bump in the hassio manifest.

@mdegat01 mdegat01 marked this pull request as draft March 13, 2026 23:30
@mdegat01

mdegat01 commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

Depends on #165512

@agners

agners commented Mar 14, 2026

Copy link
Copy Markdown
Member

By the PR you mean #127228? That PR added deprecated functions like get_supervisor_ip.

@agners The main thing that PR did that was relevant to this discussion was it removed hassio from ALLOWED_USED_COMPONENTS here: https://github.com/home-assistant/core/pull/127228/changes#diff-569f8044f69e10d196eb0d217ebfad4ca13e5b61bff3a124b1818b19c0de4bd7 . This was the reason aiohasupervisor had to be in pyproject.toml, hassfest was not enforcing that integration developers listed a dependency on the hassio integration in their manifest. This meant that they could end up in a situation where they depended on aiohasupervisor but it wasn't there at runtime because hassio wasn't installed.

Yeah, but I mean to remove those deprecated functions from that PR as well. But I realized now they got removed already in #158802. So all good 👍 .

@sairon sairon mentioned this pull request Mar 14, 2026
Merged
21 tasks
@agners agners marked this pull request as ready for review March 16, 2026 11:01
Copilot AI review requested due to automatic review settings March 16, 2026 11:01
Copilot AI reviewed Mar 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the aiohasupervisor dependency from 0.3.3 to 0.4.0. The test changes adapt to enum values (CheckType.SUPERVISOR_TRUST, UnsupportedReason.CONTENT_TRUST) that were apparently removed in the new library version, replacing them with other valid enum members.

Changes:

  • Bumps aiohasupervisor version to 0.4.0 in manifest, requirements_all.txt, and requirements_test_all.txt.
  • Updates test fixtures and assertions in test_issues.py to use CheckType.DOCKER_CONFIG and UnsupportedReason.CONNECTIVITY_CHECK in place of removed enum values.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/hassio/manifest.json Version bump to 0.4.0
requirements_all.txt Version bump to 0.4.0
requirements_test_all.txt Version bump to 0.4.0
tests/components/hassio/test_issues.py Replace removed enum values with valid alternatives

@agners agners changed the title Bump aiohasupervisor to 0.4.0 Bump aiohasupervisor to 0.4.1 Mar 16, 2026
agners
agners approved these changes Mar 16, 2026
View reviewed changes

@agners agners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #165512 merged this is ready.

I've bumped it to the just released 0.4.1 as well, which contains a small bug fix required for #164413 (see #164413 (review)).

From my side this is ready to get merged.

@sairon sairon merged commit 332bf95 into dev Mar 16, 2026
69 of 70 checks passed
@sairon sairon deleted the bump-aiohasupervisor-0.4.0 branch March 16, 2026 12:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@agners agners agners approved these changes

@sairon sairon sairon approved these changes

@edenhaus edenhaus Awaiting requested review from edenhaus

Assignees

No one assigned

Labels

by-code-owner cla-signed core dependency Pull requests marked as a dependency upgrade integration: hassio Quality Scale: internal small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdegat01 @agners @sairon